There is only one systemuser. it may not be perfect. Just another piece of evidence there is a potential problem.
1 Like
My phone is not rooted, but System user returns true !
But thatās not a problem because I only use isRooted and isEmulator 
3 Likes
I will work on the isSystemUser. I have seen some strange behaviour. I am going to add a spy package component as well, so it will look for a list of packages that are potentially dodgy.
3 Likes
Tested and working as expected! 
And just additional information: Magisk users can simply pass from the root checkers and can hide root from apps. So you may need to check if Magisk is installed or not.
2 Likes
Are you pointing out a bug, a development feature or a flaw for the sake of it? Please elaborate.
Itās just that you canāt detect Systemless Root. The way Magisk works, it canāt be detected.
3 Likes
Are you saying this is useless or are you saying you want to help solve it?
I accept my extension is not perfect. If you would like to give help on how to fix it, I would love to hear it.
Your extension is potentially very useful to developers.
It works exactly as intended. Your extension does work perfectly, and thereās nothing to fix. It does detect root, but the way Magisk is designed, itās possible to bypass any rootcheck mechanism. Thatās the beauty of Magisk, and I love it. I wouldnāt want apps blocking me because I have root or Lucky Patcher.
TL;DR: Your extension works fine. Donāt worry.
5 Likes
You could add another check to detect if the package name ācom.android.vending.billing.InAppBillingService.BINNā or ācom.android.vending.licensing.ILicensingServiceā exists. Lucky Patcher is invisible, but requires these two packages to mess with IAPs and License Verification respectively.
2 Likes
Sooo How do I get it to track Magisj? Lets figure this out and I can add it. An ideas?
That coincides with my thought of a ānasty pacakgeā lookup.
Lets gather them together and I can plug it in.
Thanks mate!
3 Likes
For good or for bad, there is no way. Itās literally impossible.
P.S. Point to be noted, Iām a user of all the āmaliciousā things being blocked. This extension will hurt me in a sense. 
3 Likes
Oh yeah, I forgot this feature for a while 
Thatās why I love Magisk 
3 Likes
What about making a component that checks the app name instead of the package name?
1 Like
Bad idea, since an App Name isnāt a unique identifier.
3 Likes
Yeah, but I guess that not so many other apps are called Magiskā¦
Guess it depends from the kind of app, and after all is the most accurate way to see if itās installed or not (as it is the only way ;___; )
1 Like
I have to admit, youāre right. I didnāt think of detecting App Name.
4 Likes
The package name cannot be changed without modifiying the packae and resigning it.
If it is not signed, well then you are root, and we get ya there.
Package name is a far better indicator I think.
4 Likes
@Franck_G28 recently implemented this in his game, and Iām just plain disappointed. If I have a choice between keeping root on all my devices, or using an app, give me SU any day.
3 Likes
Just message me about it. You say in the thread there are issues with Magisk, and I am open to suggestions. If you are disappointed, then you can help me with it. Show me where it does not work for you, and we can fix it together.